This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat: improve gnosis chain configuration #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename xdai to gnosis in chain enum - remove mention of xdai in serde/strum - add average blocktime for gnosis and chiado - mark gnosis and chiado as supporting eip 1559 and push0 - use gnosisscan as gnosis' block explorer
DaniPopes
suggested changes
Oct 17, 2023
ethers-core/src/types/chain.rs
Outdated
Comment on lines
95
to
97
| #[strum(to_string = "xdai", serialize = "gnosis", serialize = "gnosis-chain")] | ||
| #[serde(alias = "xdai", alias = "gnosis", alias = "gnosis_chain")] | ||
| XDai = 100, | ||
| #[strum(to_string = "gnosis", serialize = "gnosis-chain")] | ||
| #[serde(alias = "gnosis", alias = "gnosis_chain")] | ||
| Gnosis = 100, |
There was a problem hiding this comment.
Can you keep "xdai" as an alias on both strum and serde to avoid a breaking change?
There was a problem hiding this comment.
Oh sorry, absolutely. Addressed in ab0071b
DaniPopes
approved these changes
Oct 18, 2023
mattsse
approved these changes
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I just wanted to update Gnosis Chain's config in the lib as it was pretty outdated (Gnosis Chain underwent the Shapella upgrade recently and with it comes
push0support for example).Solution
push0