This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(etherscan): Implemented Some APIs for stats
#2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woxjro
force-pushed
the
feat/etherscan/stats
branch
2 times, most recently
from
ab15bc9
to
de1760a
Compare
The following APIs have been implemented. - https://docs.etherscan.io/api-endpoints/stats-1 - Get Total Supply of Ether (`ethsupply`) - Get Total Supply of Ether 2 (`ethsupply2`) - Get Ether Last Price (`ethprice`) - Get Total Node Count (`nodecount`)
woxjro
force-pushed
the
feat/etherscan/stats
branch
from
de1760a
to
7ccf0d8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following APIs have been implemented.
ethsupply)ethsupply2)ethprice)nodecount)Motivation
Thank you for developing such fantastic software. I'm working on a project called "lazy-etherscan",
and I would like to display statistical information about Ethereum within it.
After reviewing "ether-rs", I noticed that this functionality was not yet implemented,
so I decided to create this pull request.
Solution
I have implemented several of the statistical APIs from Etherscan's API documentation (https://docs.etherscan.io/api-endpoints/stats-1),
excluding the PRO features and "Get Ethereum Node Size". I have also added some tests.
Additionally, I needed to handle date information, so I added the "chrono" crate to "ethers-rs."
PR Checklist