Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat: extend Middleware trait customized for celo #314

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

hanyunx
Copy link
Contributor

@hanyunx hanyunx commented Jun 11, 2021

Motivation

We would like to have a customized provider for Celo so as to add more functions exclusively provided by Celo blockchain.

Solution

A new trait CeloMiddleware is added to extend the Middleware for provider, so that functions in Middleware will query APIs compatible with Ethereum while functions in CeloMiddleware will query those exclusively in Celo.

The method get_validators_bls_public_keys() is added as an example.

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supportive of having a Celo middleware. Minor nits but looks good otherwise.

ethers-providers/src/lib.rs Show resolved Hide resolved
ethers-providers/src/lib.rs Outdated Show resolved Hide resolved
@gakonst gakonst merged commit 5715bcd into gakonst:master Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants