Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix: skip 2930 tests in legacy mode / skip aws test if no id #386

Merged
merged 2 commits into from
Aug 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ethers-core/src/types/transaction/eip2930.rs
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ mod tests {
}

#[test]
#[cfg_attr(feature = "legacy", ignore)]
fn serde_eip2930_tx() {
let access_list = vec![AccessListItem {
address: Address::zero(),
Expand Down
5 changes: 4 additions & 1 deletion ethers-signers/src/aws/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,10 @@ mod tests {
#[tokio::test]
async fn it_signs_messages() {
let chain_id = 1;
let key_id = std::env::var("AWS_KEY_ID").expect("no key id");
let key_id = match std::env::var("AWS_KEY_ID") {
Ok(id) => id,
_ => return,
};
setup_tracing();
let client = env_client();
let signer = AwsSigner::new(&client, key_id, chain_id).await.unwrap();
Expand Down