This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: use once_cell with feature=std in abigen #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
LGTM - nice catch! I wonder if that was what was causing the failure in CI for abigen recently...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
once_celldependency ofethers-contract-abigenwhich has a dependency ononce_cell::sync, but doesn't pull in this mod due to thestdfeature being turned off. If this worked before, it's because all of the tests are run using Cargo withresolver = 1, which compiles one version of a dependency with all features enabled by all peer dependencies.