feature: first draft timelag middleware #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Sep 16, 2021
| ethers_providers::FilterWatcher<'_, Self::Provider, ethers_core::types::TxHash>, | ||
| Self::Error, | ||
| > { | ||
| Err(TimeLagError::Unsupported) |
There was a problem hiding this comment.
I think Unsupported is fine, curious what others think
- imports to top of file - expect with message - fill_transaction fix
gakonst
requested changes
Sep 16, 2021
gakonst
force-pushed
the
prestwich/timelag
branch
from
30d324c
to
25fe6a8
Compare
gakonst
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a TimeLag middleware that offsets tip-related requests by a constant parameter
Ke.g.
TimelagMiddleware<M, 60>will modifyeth_call,eth_getBlockNumberand other related parameters to use the current chain tip - 60 blocksThis provides a modicum of protection from reorgs
Please review
Unsupportedbehavior reasonable?