Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support human readable struct inputs #482

Merged
merged 11 commits into from
Oct 2, 2021
Merged

feat: support human readable struct inputs #482

merged 11 commits into from
Oct 2, 2021

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 1, 2021 •
edited
Loading

Motivation

Support custom structs as contract params in human readable abi

Solution

  • keep track of the function's types (input, output) in the abi parser, this is added on top the existing parser and adds a bit more verbosity in to the param parse functions...
  • reuse the existing InternalStructs when determine function inputs

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@mattsse mattsse force-pushed the matt/human-readable-struct-inputs branch from 8a616ca to fda88c3 Compare October 1, 2021 20:09
gakonst
gakonst approved these changes Oct 2, 2021
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

godlike

@gakonst gakonst merged commit 42bf983 into gakonst:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @gakonst