Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing fmt argument in error message #552

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Fix missing fmt argument in error message #552

merged 3 commits into from
Nov 3, 2021

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Nov 3, 2021 •
edited
Loading

Without this, the error message would literally be "root path '{}' is not absolute" with curly braces in it instead of the root path.

Test plan:

cd ethers-contract/ethers-contract-abigen
cargo check
cargo check --target wasm32-unknown-unknown

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

gakonst
gakonst approved these changes Nov 3, 2021
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Excellent catch! Thank you.

Also, big fan of all your macro-magic projects so really excited to see you looking at this repository!

@gakonst gakonst merged commit 325b752 into gakonst:master Nov 3, 2021
@dtolnay dtolnay deleted the fmt branch December 18, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtolnay @gakonst