Add dev-rpc middleware #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what the test failure is, will take a look today. Seems to pass when run with |
|
Seems this is the issue: ethers-rs/ethers-providers/src/provider.rs Lines 1170 to 1171 in 24f9bd0 Also, this is jammed into provider.rs because it needs access to the request. If making that |
mattsse
reviewed
Dec 3, 2021
ethers-providers/src/provider.rs
Outdated
Comment on lines
1090
to
1093
| match ok { | ||
| true => Ok(()), | ||
| false => Err(DevRpcMiddlewareError::NoSnapshotError), | ||
| } |
There was a problem hiding this comment.
an if {} else {}would be more idiomatic here
wolflo
commented
Dec 3, 2021
| ProviderError(ProviderError), | ||
|
|
||
| #[error("Could not revert to snapshot")] | ||
| NoSnapshot, |
There was a problem hiding this comment.
Maybe I misunderstood this lint, but it seems to not jive with the rest of the Error naming convention for ethers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dev-rpc feature flag to ethers-providers. This gives you a
DevRpcMiddlewarethat exposesevm_snapshotandevm_revertfor managing snapshot state.There are more methods that may be useful, but there is a bit of a mess to untangle with conflicts between documentation, hardhat, and ganache.
A lighter-weight alternative may be to just expose
provider.request()for raw requests under a dev-rpc flag.