feat(abigen): use AbiType when parsing Function abi signature fails at compile time #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
changed the title
|
Awesome and thank you so much! Tried the PR and it looks like the problems in #538 are indeed gone with this change. 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #538
Solution
The reason why #538 happened is, because ethabis native tuple parser is used to parse the
abiattribute that gets generated during abigen! expansion.abigen!is able to resolve custom datatypes at this stage and add a valid! abi signature this why.However during
EthAbiTypeexpansion, the signature can't be parsed by ethabi's tuple parser because it struggles with nested tuples. In which case we use ourAbiType::param_typetrait to construct theParamTypes, that we need for decoding, at runtime.PR Checklist