This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
chore: allow unused http_get #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
suggested changes
Dec 10, 2021
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
mattsse
force-pushed
the
matt/silence-wasm
branch
from
6d644aa
to
4f5b445
Compare
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* feat(forge create): read calldata from file It is possible to create a transaction where the calldata is too large to be passed via `argv`. See https://wiki.debian.org/CommonErrorMessages/ArgumentListTooLong for more information on this limitation. To make it possible to create these large transactions, update `forge create` so that it can read the calldata from a file. A new cli argument is added `--constructor-args-path` that conflicts with `--constructor-args`. This new argument should point to a file on the filesystem that contains a whitespace delimited list of constructor arguments. * refactor out `mut` Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Update cli/src/cmd/create.rs Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * fix: get compiling * chore: fmt with latest nightly * chore: clippy lints Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
allow unused for http_get to silence CI
Solution
PR Checklist