-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(solc): rewrite compiler passes and cache change detection #802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so far so good-really like the direction
Update
TODO
Update 2
|
@mattsse should we pull in the Forge integration tests for compilation in ethers-solc perhaps? |
debugging on patched foundry rn Also, currently we're storing absolute paths in the cache file, we can store them relatively, however it doesn't really matter since this should be always kept locally, so I guess absolute paths are fine. |
Just a doctest failing |
Update
manual testing indicates, that this appears to finally resolve the spells-mainnet cache bug
BEFORE MERGE
|
OK let's go - pray |
Motivation
Close #784
Close #727
Solution
PR Checklist