Implement RLP decoding for transactions

[Rjected]

Motivation

Currently there is no way to decode a transaction from bytes, only encode to bytes.

Solution

Implemented the Decodable trait for:

• TypedTransaction
  • TransactionRequest
  • Eip2930TransactionRequest
  • Eip1559TransactionRequest
• NameOrAddress
• Transaction

This change uses rlp_derive for the Decodable implementation on AccessListItem and AccessList.

This also adjusts each variant of TypedTransaction to contain the chain_id, and removes chain_id it from the rlp_signed and sighash functions.

Fixes #561

PR Checklist

• Added Tests
• Added Documentation
• Updated the changelog

[gakonst]

Seems like something is missing when testing against a live network?

failures:
281

282
---- nonce_manager stdout ----
283
thread 'nonce_manager' panicked at 'called Result::unwrap() on an Err value: MiddlewareError(MiddlewareError(JsonRpcClientError(JsonRpcError(JsonRpcError { code: -32602, message: "transaction could not be decoded: chainId is required for EIP-2718 style signatures", data: None }))))', ethers-

[gakonst]

directionally this looks great - just think there's some decoding bug in testnet so i'd look at that

[gakonst]

@Rjected hey just checking up here, what do your plans look like for getting this over the line? can we help?

[rakita]

Didnt dive into code, but maybe this can help (or at least act as reference). It is impl of types transaction with good licence:
https://github.com/gnosis/reth/tree/rakita/txpool/tx_score/crates/core/src/transaction

[Rjected]

Hey, yeah I have been pretty busy but I fixed the failing tests. Since the workflow needs to be approved, here's the workflow on my fork: https://github.com/Rjected/ethers-rs/actions/runs/1763919095.

[gakonst]

sick