Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Remove entire cache folder, not just contents #820

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Remove entire cache folder, not just contents #820

merged 1 commit into from
Jan 20, 2022

Conversation

onbjerg
Copy link
Collaborator

@onbjerg onbjerg commented Jan 20, 2022

Should fix foundry-rs/foundry#322 (?)

@gakonst gakonst merged commit 2945104 into gakonst:master Jan 20, 2022
@onbjerg onbjerg deleted the remove-cache-folder branch January 20, 2022 09:01
@mds1
Copy link

mds1 commented Jan 20, 2022

Hm, I'm not sure we want to remove the whole cache folder. For people migrating from Hardhat to Foundry, this will also delete the hardhat cache that lives in cache/hardhat-network-fork. Seems it'd be better UX to be more selective and only delete cache files/folders from foundry or ethers-rs

@mattsse
Copy link
Collaborator

mattsse commented Jan 20, 2022

this also broke the clean function because cache_path points to the file, not the dir, so std::fs::remove_dir_all(self.cache_path()) always fails.

mattsse added a commit to mattsse/ethers-rs that referenced this pull request Jan 20, 2022
@mattsse
Revert "Remove entire cache folder, not just contents (gakonst#820)"
56a77c3 
This reverts commit 2945104.
@mattsse mattsse mentioned this pull request Jan 20, 2022
Merged
@gakonst
Copy link
Owner

gakonst commented Jan 20, 2022

ugh i rushed to merge this, let's revert

gakonst added a commit that referenced this pull request Jan 20, 2022
@gakonst
Revert "Remove entire cache folder, not just contents (#820)"
141e2f1 
This reverts commit 2945104.
gakonst pushed a commit that referenced this pull request Jan 20, 2022
@mattsse
Revert "Remove entire cache folder, not just contents (#820)" (#821)
fe12d10 
This reverts commit 2945104.
This was referenced Jan 20, 2022
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forge clean does not remove out folder
4 participants
@onbjerg @mds1 @mattsse @gakonst