-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust spine basic API #111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuoLei1990
reviewed
Oct 29, 2024
GuoLei1990
reviewed
Oct 29, 2024
GuoLei1990
reviewed
Oct 29, 2024
GuoLei1990
reviewed
Oct 29, 2024
GuoLei1990
reviewed
Oct 29, 2024
GuoLei1990
reviewed
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adjust spine basic API.
Changes
Additionally create and store animationData, which is generated based on the original skeletonData. Add a skeletonData cache to manage resource reference counting relationships based on skeletonData.
Impact:
After deprecating the resource API, the recommended way for users to create Spine animations will change."
old:
new:
Additional Context
Related to issue: #109
Please review the changes and provide feedback on the caching logic and implementation details.