Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: gizmo event #221

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Feat: gizmo event #221

merged 2 commits into from
Aug 7, 2023

Conversation

JujieX
Copy link
Member

@JujieX JujieX commented Aug 7, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix: #220

@JujieX JujieX added the enhancement New feature or request label Aug 7, 2023
@JujieX JujieX added this to the 1.1 milestone Aug 7, 2023
@JujieX JujieX requested a review from MrKou47 August 7, 2023 02:22
@JujieX JujieX self-assigned this Aug 7, 2023
@JujieX JujieX requested a review from zhuxudong August 7, 2023 02:23
Copy link
Member

@zhuxudong zhuxudong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e567f89) 22.19% compared to head (76e0a31) 22.19%.
Report is 4 commits behind head on main.

❗ Current head 76e0a31 differs from pull request most recent head f7a5d82. Consider uploading reports for the commit f7a5d82 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   22.19%   22.19%           
=======================================
  Files          11       11           
  Lines         473      473           
  Branches       70       70           
=======================================
  Hits          105      105           
  Misses        364      364           
  Partials        4        4           
Files Changed Coverage Δ
packages/controls/src/FreeControl.ts 7.84% <100.00%> (ø)
packages/controls/src/OrbitControl.ts 30.98% <100.00%> (ø)
packages/controls/src/OrthoControl.ts 7.95% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrKou47 MrKou47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JujieX JujieX requested a review from eyworldwide August 7, 2023 02:38
@JujieX JujieX merged commit c443775 into galacean:main Aug 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants