Add export for builtin shader chunks

[Sway007]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

• New Features

  • Introduced a new internal export for fragmentList, enhancing visibility control.

• Documentation

  • Added documentation comments to clarify the intended usage of fragmentList for developers.

[coderabbitai]

Walkthrough

The changes introduce an export statement for fragmentList in the shader module, designating it as an internal entity with the @internal annotation. This adjustment does not impact the functionality of the registerShader function but enhances visibility control for fragmentList, indicating its intended internal use. Additionally, a documentation comment clarifies the usage expectations for developers.

Changes

File	Change Summary
packages/shaderlab/src/index.ts	Added export { fragmentList }; with @internal annotation.

Possibly related PRs

• Open shader core API by ShaderLab #274: Involves changes to the shader core API, potentially related to the internal visibility control introduced for fragmentList.
• Enhancement Shader API #286: Modifies LightIndirectPBR.glsl, which may interact with the shader API's internal structure, similar to the changes in the main PR.

Suggested labels

enhancement, shader

Poem

In the shader's glow, a list we hide,
With an internal mark, it now abides.
A rabbit hops, with joy in sight,
For clearer paths, and code so bright.
Let developers tread with care,
In this module, secrets we share! 🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8024cc6 and ac9ac8f.

Files selected for processing (1)

• packages/shaderlab/src/index.ts (1 hunks)

Additional comments not posted (1)

packages/shaderlab/src/index.ts (1)

24-28: LGTM!

The code changes are approved. Exporting fragmentList and annotating it with @internal is a good way to make it available for internal use within the module while clearly communicating the intent that it should not be used externally.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cptbtptpbcptdtptp]

+1