Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group listener error #315

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp commented Dec 13, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

  • New Features

    • Multiple packages have been updated to a new alpha version (1.4.0-alpha.1), indicating potential new features or changes.
  • Bug Fixes

    • Adjusted the way the flagManager is accessed in the Group class for improved functionality.
  • Documentation

    • Added internal documentation for the fragmentList variable in the shader lab.
  • Style

    • New headers and properties added to the shader "PBR.gs" for enhanced material options.
  • Chores

    • Updated version numbers in various package.json files across multiple packages.

Copy link

coderabbitai bot commented Dec 13, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the version numbers of multiple packages within the @galacean/engine-toolkit from 1.3.9 to 1.4.0-alpha.1, indicating a transition to alpha releases. The changes are primarily reflected in the package.json files of various packages, with no other modifications to dependencies, scripts, or metadata. Additionally, there are functional changes in the Group class and enhancements in the shader files, including new properties and internal exports.

Changes

File Path Change Summary
packages/auxiliary-lines/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/controls/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/custom-gltf-parser/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/custom-material/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/draco/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/dynamic-bone/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/framebuffer-picker/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/galacean-engine-toolkit/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/geometry-sketch/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/gizmo/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/input-logger/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/lines/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/navigation-gizmo/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/outline/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/shaderlab/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/skeleton-viewer/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/stats/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/tween/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/way-point/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/xr/package.json Version updated from 1.3.9 to 1.4.0-alpha.1
packages/gizmo/src/Group.ts Updated _applyAdd method to access flagManager directly from entity instead of entity.transform
packages/shaderlab/src/index.ts Added internal export for fragmentList with a JSDoc comment
packages/shaderlab/src/shaders/PBR.gs Added new headers and properties for "Thin Film Iridescence" and "Sheen"; removed "Conditional Macros" section
packages/shaderlab/src/shaders/shadingPBR/index.ts Modified imports and exports to replace LightProbe with LightIndirectFunctions

Possibly related PRs

  • Enhancement Shader API #286: Enhances the Shader API, potentially related to the version updates in shader-related packages.
  • ShaderLab PBR support Iridescence #310: Introduces new properties related to iridescence in the PBR.gs shader, aligning with version updates in shader packages.
  • pbr sheen #312: Adds new properties related to sheen in the PBR.gs shader, connecting to version updates in shader packages.

Suggested reviewers

  • JujieX
  • gz65555

🐰 In the garden where changes bloom,
New versions rise, dispelling gloom.
Alpha whispers in the air,
With features fresh, we show we care.
Hop along, let’s celebrate,
For brighter tools, we can’t wait! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3be869b and eb65940.

⛔ Files ignored due to path filters (7)
  • packages/custom-material/src/advanced-shader/thinfilm/IridescenceIndirectLight.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/BRDF.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/FragmentPBR.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/LightDirectPBR.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/LightIndirectFunctions.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/LightIndirectPBR.glsl is excluded by !**/*.glsl
  • packages/shaderlab/src/shaders/shadingPBR/ReflectionLobe.glsl is excluded by !**/*.glsl
📒 Files selected for processing (24)
  • packages/auxiliary-lines/package.json (1 hunks)
  • packages/controls/package.json (1 hunks)
  • packages/custom-gltf-parser/package.json (1 hunks)
  • packages/custom-material/package.json (1 hunks)
  • packages/draco/package.json (1 hunks)
  • packages/dynamic-bone/package.json (1 hunks)
  • packages/framebuffer-picker/package.json (1 hunks)
  • packages/galacean-engine-toolkit/package.json (1 hunks)
  • packages/geometry-sketch/package.json (1 hunks)
  • packages/gizmo/package.json (1 hunks)
  • packages/gizmo/src/Group.ts (1 hunks)
  • packages/input-logger/package.json (1 hunks)
  • packages/lines/package.json (1 hunks)
  • packages/navigation-gizmo/package.json (1 hunks)
  • packages/outline/package.json (1 hunks)
  • packages/shaderlab/package.json (1 hunks)
  • packages/shaderlab/src/index.ts (1 hunks)
  • packages/shaderlab/src/shaders/PBR.gs (1 hunks)
  • packages/shaderlab/src/shaders/shadingPBR/index.ts (2 hunks)
  • packages/skeleton-viewer/package.json (1 hunks)
  • packages/stats/package.json (1 hunks)
  • packages/tween/package.json (1 hunks)
  • packages/way-point/package.json (1 hunks)
  • packages/xr/package.json (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cptbtptpbcptdtptp cptbtptpbcptdtptp changed the base branch from main to dev/1.4 December 13, 2024 09:00
@cptbtptpbcptdtptp cptbtptpbcptdtptp merged commit bbc8901 into galacean:dev/1.4 Dec 13, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant