chore: format code

galacean · Dec 2, 2024 · 5d4e3f7 · 5d4e3f7
1 parent c45b295
commit 5d4e3f7
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 5 deletions.
diff --git a/packages/core/src/RenderPipeline/BasicRenderPipeline.ts b/packages/core/src/RenderPipeline/BasicRenderPipeline.ts
@@ -122,14 +122,26 @@ export class BasicRenderPipeline {
 
     // Check if need to create internal color texture or grab texture
     if (independentCanvasEnabled) {
+      let depthFormat: TextureFormat;
+      if (camera.renderTarget) {
+        depthFormat = camera.renderTarget._depthFormat;
+      } else if (rhi.context.depth && rhi.context.stencil) {
+        depthFormat = TextureFormat.Depth24Stencil8;
+      } else if (rhi.context.depth) {
+        depthFormat = TextureFormat.Depth24;
+      } else if (rhi.context.stencil) {
+        depthFormat = TextureFormat.Stencil;
+      } else {
+        depthFormat = null;
+      }
       const viewport = camera.pixelViewport;
       const internalColorTarget = PipelineUtils.recreateRenderTargetIfNeeded(
         engine,
         this._internalColorTarget,
         viewport.width,
         viewport.height,
         camera._getInternalColorTextureFormat(),
-        camera.renderTarget ? camera.renderTarget._depthFormat : TextureFormat.Depth24Stencil8,
+        depthFormat,
         false,
         false,
         msaaSamples,

diff --git a/packages/rhi-webgl/src/WebGLGraphicDevice.ts b/packages/rhi-webgl/src/WebGLGraphicDevice.ts
@@ -404,10 +404,38 @@ export class WebGLGraphicDevice implements IHardwareRenderer {
     gl.bindFramebuffer(gl.READ_FRAMEBUFFER, srcFrameBuffer);
     gl.bindFramebuffer(gl.DRAW_FRAMEBUFFER, destFrameBuffer);
 
-    const blitMask =
-      (needBlitColor ? gl.COLOR_BUFFER_BIT : 0) |
-      (needBlitDepth ? gl.DEPTH_BUFFER_BIT : 0) |
-      (needBlitStencil ? gl.STENCIL_BUFFER_BIT : 0);
+    let blitMask = needBlitColor ? gl.COLOR_BUFFER_BIT : 0;
+
+    if (needBlitDepth || needBlitStencil) {
+      // @ts-ignore
+      const depthFormat = destRT._depthFormat;
+
+      if (needBlitDepth) {
+        if (
+          depthFormat === TextureFormat.Depth ||
+          (depthFormat >= TextureFormat.DepthStencil && depthFormat <= TextureFormat.Depth32Stencil8)
+        ) {
+          blitMask |= gl.DEPTH_BUFFER_BIT;
+        } else {
+          Logger.warn(`Do not clear depth, or set depth format of target which is ${TextureFormat[depthFormat]} now.`);
+        }
+      }
+
+      if (needBlitStencil) {
+        if (
+          depthFormat === TextureFormat.Stencil ||
+          depthFormat === TextureFormat.DepthStencil ||
+          depthFormat >= TextureFormat.Depth24Stencil8 ||
+          depthFormat >= TextureFormat.Depth32Stencil8
+        ) {
+          blitMask |= gl.STENCIL_BUFFER_BIT;
+        } else {
+          Logger.warn(
+            `Do not clear stencil, or set stencil format of target which is ${TextureFormat[depthFormat]} now.`
+          );
+        }
+      }
+    }
 
     const xStart = viewport.x * srcWidth;
     const xEnd = xStart + blitWidth;