Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about camera aspect ratio #1333

Closed
cptbtptpbcptdtptp opened this issue Jan 11, 2023 · 1 comment · Fixed by #1872
Closed

Question about camera aspect ratio #1333

cptbtptpbcptdtptp opened this issue Jan 11, 2023 · 1 comment · Fixed by #1872
Assignees
@GuoLei1990
Labels
Bug Something isn't working camera high priority High priority issue rendering Rendering related functions
Milestone
1.2

Comments

@cptbtptpbcptdtptp
Copy link
Collaborator

When the camera sets the renderTarget, should its aspectRatio follow the canvas or the renderTarget
@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Jan 11, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp added design engine design Breaking breaking change labels Jan 11, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp added this to the 1.0 milestone Jan 11, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp added the Bug Something isn't working label Jan 17, 2023
@GuoLei1990 GuoLei1990 modified the milestones: 1.0, 1.1 May 18, 2023
@GuoLei1990 GuoLei1990 modified the milestones: 1.1, 1.2 Oct 7, 2023
@GuoLei1990 GuoLei1990 assigned GuoLei1990 and unassigned zhuxudong Oct 7, 2023
@GuoLei1990 GuoLei1990 added high priority High priority issue rendering Rendering related functions and removed Breaking breaking change design engine design labels Oct 7, 2023
@GuoLei1990
Copy link
Member

Follow the renderTagrget

@GuoLei1990 GuoLei1990 linked a pull request Nov 10, 2023 that will close this issue
Fix camera aspect ratio #1872
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuoLei1990 GuoLei1990

Labels
Bug Something isn't working camera high priority High priority issue rendering Rendering related functions
Projects
No open projects
Milestone 1.2 iteration plan
Status: Done
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Fix camera aspect ratio GuoLei1990/galacean-engine
4 participants
@GuoLei1990 @gz65555 @cptbtptpbcptdtptp @zhuxudong