Fix camera aspect ratio #1872
Merged
Fix camera aspect ratio #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev/1.2 #1872 +/- ##
===========================================
- Coverage 66.71% 66.64% -0.07%
===========================================
Files 472 472
Lines 23799 23802 +3
Branches 3393 3392 -1
===========================================
- Hits 15877 15864 -13
- Misses 6732 6745 +13
- Partials 1190 1193 +3
☔ View full report in Codecov by Sentry. |
cptbtptpbcptdtptp
requested changes
Nov 10, 2023
|
|
||
| const viewport = this._viewport; |
There was a problem hiding this comment.
The _lastAspectSize attribute can be optimized.
cptbtptpbcptdtptp
pushed a commit
to cptbtptpbcptdtptp/engine
that referenced
this pull request
Jan 16, 2024
* fix: camera aspect ratio
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: