Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and optimize texture structure #319

Closed
GuoLei1990 opened this issue Jun 7, 2021 · 0 comments · Fixed by #715
Closed

Simplify and optimize texture structure #319

GuoLei1990 opened this issue Jun 7, 2021 · 0 comments · Fixed by #715
Assignees
@GuoLei1990 @zhuxudong
Labels
high priority High priority issue
Milestone
0.7

Comments

@GuoLei1990
Copy link
Member

GuoLei1990 commented Jun 7, 2021 •
edited
Loading

Current texture design should improve.

  • Maybe combine Texrure2D and RenderColorTexture.
  • Maybe combine TexrureCube and RenderColorTexture.

Describe alternatives you've considered

  • RenderColorTexture's autoGenerateMipmap is not friendly to Texrure2D.
  • RenderColorTexture's format is not equal to Texture2D's format.

Design: @GuoLei1990

PR: @GuoLei1990

PR reviewers: @cptbtptpbcptdtptp , @zhuxudong , @GuoLei1990
@GuoLei1990 GuoLei1990 added this to the 0.5 milestone Jun 7, 2021
@GuoLei1990 GuoLei1990 self-assigned this Jun 7, 2021
@GuoLei1990 GuoLei1990 linked a pull request Jun 7, 2021 that will close this issue
feat: RenderColorTexture can be written by pixelbuffer and image #317
Closed
3 tasks
@zhuxudong zhuxudong linked a pull request Jun 15, 2021 that will close this issue
feat: RenderColorTexture can be written by pixelbuffer and image #335
Closed
3 tasks
@GuoLei1990 GuoLei1990 added the medium priority Medium priority issue label Jun 28, 2021
@GuoLei1990 GuoLei1990 modified the milestones: 0.5, 0.6 Aug 13, 2021
@GuoLei1990 GuoLei1990 modified the milestones: 0.6, 0.7 Nov 9, 2021
@GuoLei1990 GuoLei1990 added high priority High priority issue and removed medium priority Medium priority issue labels Feb 7, 2022
@GuoLei1990 GuoLei1990 mentioned this issue Mar 1, 2022
Closed
22 tasks
@GuoLei1990 GuoLei1990 linked a pull request Mar 30, 2022 that will close this issue
Optimization texture structure #715
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuoLei1990 GuoLei1990

@zhuxudong zhuxudong

Labels
high priority High priority issue
Projects
None yet
Milestone
0.7
2 participants
@GuoLei1990 @zhuxudong