Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationClip support any target #1009

Merged
merged 125 commits into from
Oct 10, 2022

Conversation

luzhuang
Copy link
Contributor

@luzhuang luzhuang commented Sep 6, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@luzhuang luzhuang added the animation Built-in animation system related functions label Sep 6, 2022
@luzhuang luzhuang added this to the 0.9 milestone Sep 6, 2022
@luzhuang luzhuang requested a review from GuoLei1990 September 6, 2022 16:29
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Base: 36.50% // Head: 36.07% // Decreases project coverage by -0.43% ⚠️

Coverage data is based on head (f2aa621) compared to base (b40f07c).
Patch coverage: 10.72% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/0.9    #1009      +/-   ##
===========================================
- Coverage    36.50%   36.07%   -0.44%     
===========================================
  Files          333      341       +8     
  Lines        14821    15059     +238     
  Branches      2273     2284      +11     
===========================================
+ Hits          5410     5432      +22     
- Misses        8806     9007     +201     
- Partials       605      620      +15     
Impacted Files Coverage Δ
...ges/core/src/2d/assembler/SimpleSpriteAssembler.ts 24.32% <ø> (ø)
...ges/core/src/2d/assembler/SlicedSpriteAssembler.ts 2.81% <ø> (ø)
...es/core/src/animation/AnimationClipCurveBinding.ts 10.00% <0.00%> (-90.00%) ⬇️
packages/core/src/animation/Animator.ts 0.28% <0.00%> (+0.07%) ⬆️
...s/core/src/animation/internal/AnimatorStateData.ts 100.00% <ø> (ø)
...ages/core/src/animation/internal/CrossCurveData.ts 100.00% <ø> (ø)
packages/core/src/base/StaticInterfaceImplement.ts 100.00% <ø> (ø)
packages/core/src/lighting/LightManager.ts 31.14% <ø> (ø)
packages/core/src/particle/ParticleRenderer.ts 0.93% <0.00%> (-0.01%) ⬇️
packages/loader/src/gltf/parser/AnimationParser.ts 0.86% <0.00%> (ø)
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 changed the title Feat/support custom animationClip Support custom animationClip Sep 26, 2022
@GuoLei1990 GuoLei1990 changed the title Support custom animationClip Support animationClip custom taeget Sep 26, 2022
* @internal
*/
static _lerpValue(srcValue: boolean, destValue: boolean): boolean {
return destValue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe is srcValue?

@GuoLei1990
Copy link
Member

De temp file

@GuoLei1990 GuoLei1990 added the enhancement New feature or request label Oct 10, 2022
@GuoLei1990 GuoLei1990 changed the title Support animationClip custom target AnimationClip support any target Oct 10, 2022
@GuoLei1990 GuoLei1990 merged commit 58b5d74 into galacean:dev/0.9 Oct 10, 2022
@GuoLei1990 GuoLei1990 linked an issue Oct 10, 2022 that may be closed by this pull request
@luzhuang luzhuang mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animation Built-in animation system related functions enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Animator support custom animation by other components
3 participants