Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor skybox using infinity matrix #1048

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Refactor skybox using infinity matrix #1048

merged 4 commits into from
Sep 20, 2022

Conversation

yangfengzzz
Copy link
Member

@yangfengzzz yangfengzzz commented Sep 15, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Use epsilon-infinity projection matrix for skybox which will solve orthographic camera render failure bug.
http://terathon.com/gdc07_lengyel.pdf

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@yangfengzzz yangfengzzz added enhancement Rendering Rendering related functions high priority High priority issue labels Sep 15, 2022
@yangfengzzz yangfengzzz added this to the 0.9 milestone Sep 15, 2022
@yangfengzzz yangfengzzz self-assigned this Sep 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Base: 33.45% // Head: 33.45% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (28cc156) compared to base (3cca4ab).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/0.9    #1048      +/-   ##
===========================================
- Coverage    33.45%   33.45%   -0.01%     
===========================================
  Files          333      333              
  Lines        14798    14805       +7     
  Branches      2271     2271              
===========================================
+ Hits          4951     4953       +2     
- Misses        9297     9304       +7     
+ Partials       550      548       -2     
Impacted Files Coverage Δ
packages/core/src/Camera.ts 9.93% <ø> (ø)
...ges/core/src/RenderPipeline/BasicRenderPipeline.ts 13.70% <0.00%> (+2.22%) ⬆️
packages/core/src/sky/Sky.ts 3.12% <0.00%> (-96.88%) ⬇️
packages/math/src/Color.ts 78.78% <0.00%> (+3.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

packages/core/src/sky/Sky.ts Outdated Show resolved Hide resolved
packages/core/src/sky/Sky.ts Show resolved Hide resolved
packages/core/src/sky/Sky.ts Outdated Show resolved Hide resolved
packages/core/src/sky/Sky.ts Outdated Show resolved Hide resolved
@GuoLei1990 GuoLei1990 merged commit 6b8b696 into galacean:dev/0.9 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority High priority issue Rendering Rendering related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show skybox when camera is orthographic Add Infinite projection matrix for sky system.
3 participants