Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sprite transform error when rotates. #1053

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Fix sprite transform error when rotates. #1053

merged 1 commit into from
Sep 16, 2022

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

image
An operator was missed when synchronizing Z.

@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Sep 15, 2022
@cptbtptpbcptdtptp cptbtptpbcptdtptp added bug Something isn't working 2D high priority High priority issue labels Sep 15, 2022
@cptbtptpbcptdtptp cptbtptpbcptdtptp added this to the 0.9 milestone Sep 15, 2022
singlecoder
singlecoder approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@singlecoder singlecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@cptbtptpbcptdtptp
Copy link
Collaborator Author

cptbtptpbcptdtptp commented Sep 15, 2022 •
edited
Loading

Since in Simple mode, the scaling of Sprite is proportional, it can be deduced according to the following formula:
image

@cptbtptpbcptdtptp
Copy link
Collaborator Author

Since in Sliced ​​mode, the scaling of Sprite is not proportional, it can be deduced according to the following formula:
image

@GuoLei1990 GuoLei1990 merged commit a0ea9d7 into galacean:main Sep 16, 2022
@GuoLei1990 GuoLei1990 changed the title fix: sprite transform error when rotates. Fix sprite transform error when rotates. Sep 16, 2022
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Sep 22, 2022
@GuoLei1990
Merge branch 'main' into dev/0.9
5121f7e 
* main:
  v0.8.0-beta.26
  feat: shader add properties get ability (galacean#1060)
  Fix scene root entity destroy bug (galacean#1062)
  Fix call `engine.destroy()` crash  in `Script` (galacean#1059)
  Fix physics system stablity (galacean#1047)
  v0.8.0-beta.25
  Fix script onDisable() error call bug (galacean#1055)
  fix: sprite transform error when rotates (galacean#1053)
  feat: remove throw (galacean#1052)
  Update README.md
  Update README.md
  v0.8.0-beta.24
  Fix `TextRenderer` render error (galacean#1040)
  v0.8.0-beta.23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

@singlecoder singlecoder singlecoder approved these changes

Assignees

@cptbtptpbcptdtptp cptbtptpbcptdtptp

Labels
bug Something isn't working high priority High priority issue
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@cptbtptpbcptdtptp @GuoLei1990 @singlecoder