Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sunlight error #1857

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

zhuxudong
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@zhuxudong zhuxudong added the bug Something isn't working label Nov 2, 2023
@zhuxudong zhuxudong requested a review from GuoLei1990 November 2, 2023 02:59
@zhuxudong zhuxudong self-assigned this Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 133 lines in your changes are missing coverage. Please review.

Comparison is base (e524dd2) 65.07% compared to head (f1a483e) 66.72%.
Report is 31 commits behind head on dev/1.2.

❗ Current head f1a483e differs from pull request most recent head 3bff810. Consider uploading reports for the commit 3bff810 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.2    #1857      +/-   ##
===========================================
+ Coverage    65.07%   66.72%   +1.64%     
===========================================
  Files          473      472       -1     
  Lines        23801    23800       -1     
  Branches      3381     3394      +13     
===========================================
+ Hits         15488    15880     +392     
+ Misses        7116     6735     -381     
+ Partials      1197     1185      -12     
Files Coverage Δ
packages/core/src/2d/enums/SpriteModifyFlags.ts 100.00% <ø> (ø)
packages/core/src/2d/sprite/Sprite.ts 96.80% <100.00%> (+0.01%) ⬆️
packages/core/src/Engine.ts 87.69% <100.00%> (+0.65%) ⬆️
packages/core/src/Entity.ts 85.58% <100.00%> (+0.17%) ⬆️
packages/core/src/RenderPipeline/RenderQueue.ts 47.27% <100.00%> (+0.60%) ⬆️
packages/core/src/animation/Animator.ts 63.48% <ø> (+1.11%) ⬆️
packages/core/src/asset/ResourceManager.ts 60.28% <100.00%> (ø)
packages/core/src/clone/CloneManager.ts 78.84% <100.00%> (+0.84%) ⬆️
packages/core/src/clone/ComponentCloner.ts 100.00% <ø> (ø)
packages/core/src/lighting/Light.ts 92.30% <100.00%> (ø)
... and 32 more

... and 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit 98ead75 into galacean:dev/1.2 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants