Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix call transform.translate error after call transform.position = new Vector3(x, x, x) #1889

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fix call transform.translate error after call transform.position = new Vector3(x, x, x) #1889

merged 1 commit into from
Nov 29, 2023

Conversation

singlecoder
Copy link
Member 

const entity = rootEntity.createChild('test');
const { transform } = entity;
transform.position = new Vector3(100, 0, 0);
transform.translate(1, 0, 0);
console.log(transform.worldPosition.x);

expected output: 101
actual output: 1

@singlecoder singlecoder added the bug Something isn't working label Nov 29, 2023
@singlecoder singlecoder self-assigned this Nov 29, 2023
cptbtptpbcptdtptp
cptbtptpbcptdtptp approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit ce08616 into galacean:main Nov 29, 2023
GuoLei1990 added a commit that referenced this pull request Dec 3, 2023
@GuoLei1990
Merge branch 'main' into dev/1.2
03d3d87 
* main:
  "v1.1.0-beta.24"
  Fix rollup shaderlab es module package (#1888)
  fix(transform): fix translate error (#1889)
  Fix set texture ref count error in ShaderData (#1887)
  "v1.1.0-beta.23"
  feat: add adapter miniprogram config (#1886)
  "v1.1.0-beta.22"
  Provide `shaderlab` compiled AST related context for the VSCode extension (#1882)
  KTX2Loader support auto priority (#1885)
  "v1.1.0-beta.21"
  fix(scene): fix merge scene error (#1883)
  "v1.1.0-beta.20"
  feat: atlas support ktx2 (#1879)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

@cptbtptpbcptdtptp cptbtptpbcptdtptp cptbtptpbcptdtptp approved these changes

Assignees

@singlecoder singlecoder

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@singlecoder @GuoLei1990 @cptbtptpbcptdtptp