New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`ParticleRenderer` support bounds and frustum culling #1963

Merged

GuoLei1990 merged 113 commits into galacean:main from JujieX:feat/particleBBox

Jun 7, 2024

Member

JujieX commented Jan 11, 2024 •

edited

Loading

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Calculate ParticleRenderer BoundingBox


          feat: calculate particleRenderer boundingBox

e2a5cdb

JujieX added the particle label

JujieX added this to the 1.2 milestone

JujieX requested a review from GuoLei1990

January 11, 2024 08:25

JujieX self-assigned this

Collaborator

cptbtptpbcptdtptp commented Jan 15, 2024

According to the subsequent design of localbounds, this should be better:

Member Author

JujieX commented Jan 15, 2024

According to the subsequent design of localbounds, this should be better:

Currently the result is the local bounds of the renderer.
Each calculation part is correspond to its GPU equivalent on a one-to-one basis.

GuoLei1990 requested a review from cptbtptpbcptdtptp

January 16, 2024 06:09

GuoLei1990 requested changes

View reviewed changes

Member

GuoLei1990 left a comment

Add unit tets

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/modules/ParticleCompositeCurve.ts Outdated Show resolved Hide resolved

packages/core/src/particle/modules/ParticleCompositeCurve.ts Outdated Show resolved Hide resolved

JujieX added 3 commits

January 17, 2024 15:20


          fix: shape calculate move into each type

b732e7a


          fix: get local and world bounds

85113fe


          fix: use private static vector3

07f9af9

GuoLei1990 added the enhancement label

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/modules/shape/BoxShape.ts Outdated Show resolved Hide resolved

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/ParticleGenerator.ts Show resolved Hide resolved

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

packages/core/src/particle/ParticleRenderer.ts Outdated Show resolved Hide resolved

JujieX added 7 commits

January 29, 2024 15:15


          Merge branch 'dev/1.2' of github.com:galacean/runtime into feat/parti…

917f655

…cleBBox


          fix: opt code


          fix: get bounds

8bc6974


          feat: add unit test

c80b5bf


          feat: simulation space world

5b31b26


          feat: add rotation into consideration

05e50a7


          fix: add timeout for test

5bc60d6

JujieX added 8 commits

June 6, 2024 17:34


          fix: opt code

395df1b


          fix: opt code

a5f7171


          fix: opt code

ba37308


          fix: hemisphere algo

c59bbfa


          fix: opt code

1f14bd5


          fix: opt code

3b2954c


          fix: opt shape algo

b33a9cf


          fix: opt code

52b116b

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/ParticleRenderer.ts Outdated Show resolved Hide resolved

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/modules/ParticleCompositeCurve.ts Outdated Show resolved Hide resolved

packages/core/src/particle/modules/ParticleCompositeCurve.ts Show resolved Hide resolved

packages/core/src/particle/modules/ParticleCompositeCurve.ts Show resolved Hide resolved


          fix: onCurveChange bind

9903a49

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/modules/ParticleCurve.ts Show resolved Hide resolved

packages/core/src/particle/modules/ParticleCurve.ts Outdated Show resolved Hide resolved

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/ParticleRenderer.ts Show resolved Hide resolved

GuoLei1990 reviewed

View reviewed changes

packages/core/src/particle/modules/ParticleCompositeCurve.ts Outdated Show resolved Hide resolved

packages/core/src/particle/modules/shape/BoxShape.ts Outdated Show resolved Hide resolved

JujieX added 2 commits

June 6, 2024 21:07


          fix: opt code

4de0d1c


          fix: opt code

b73dba1

GuoLei1990 changed the title ~~Feat: Calculate ParticleRenderer BoundingBox~~ ParticleRenderer support bounds and frustum culling

JujieX added 6 commits

June 6, 2024 21:24


          fix: opt code

787647f


          fix: opt code

2a8efb8


          Merge branch 'main' of github.com:galacean/runtime into feat/particle…

9fe522a

…BBox


          fix: opt code

bf5d166


          fix: opt code

46d250e


          fix: opt code

89d5fb7

GuoLei1990 changed the title ~~ParticleRenderer support bounds and frustum culling~~ ParticleRenderer support bounds and frustum culling


          fix: opt code

de600a6

GuoLei1990 merged commit 6d0fdd8 into galacean:main

6 checks passed

GuoLei1990 added a commit that referenced this pull request


          Revert "ParticleRenderer support bounds and frustum culling (#1963)"

057a546

This reverts commit 6d0fdd8.

GuoLei1990 mentioned this pull request

Revert "ParticleRenderer support bounds and frustum culling" #2109

Merged

GuoLei1990 added a commit that referenced this pull request


          Revert "ParticleRenderer support bounds and frustum culling (#1963)" (

df181dd

#2109)

This reverts commit 6d0fdd8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement particle