Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blend shape error if use quantization #2031

Merged
merged 6 commits into from
Mar 15, 2024

Conversation

GuoLei1990
Copy link
Member

@GuoLei1990 GuoLei1990 commented Mar 13, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines

  • Tests for the changes have been added (for bug fixes / features)

  • Docs have been added / updated (for bug fixes / features)

  • Fix blend shape data read error when use use quantization

  • Fix error in PR https://github.com/galacean/runtime/pull/2013,(When undefined, the accessor MUST be initialized with zeros, not bufferview zero)

@GuoLei1990 GuoLei1990 added bug Something isn't working animation Built-in animation system related functions glTF labels Mar 13, 2024
@zhuxudong
Copy link
Member

zhuxudong commented Mar 15, 2024

I'm sorry, the model play "Right", "Up" is error, check it in babylon

@GuoLei1990 GuoLei1990 merged commit 1dda49d into galacean:main Mar 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animation Built-in animation system related functions bug Something isn't working glTF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants