-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GLSL ES3.00 shader syntax compatibility #2048
Merged
GuoLei1990
merged 8 commits into
galacean:main
from
zhuxudong:fix/glsl300-compile-ignore
Apr 2, 2024
Merged
Improve GLSL ES3.00 shader syntax compatibility #2048
GuoLei1990
merged 8 commits into
galacean:main
from
zhuxudong:fix/glsl300-compile-ignore
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2048 +/- ##
==========================================
+ Coverage 66.05% 66.10% +0.05%
==========================================
Files 460 460
Lines 22996 23000 +4
Branches 3369 3369
==========================================
+ Hits 15190 15205 +15
+ Misses 6645 6631 -14
- Partials 1161 1164 +3 ☔ View full report in Codecov by Sentry. |
eyworldwide
approved these changes
Mar 25, 2024
GuoLei1990
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add unit test
GuoLei1990
reviewed
Apr 2, 2024
GuoLei1990
reviewed
Apr 2, 2024
GuoLei1990
reviewed
Apr 2, 2024
GuoLei1990
reviewed
Apr 2, 2024
GuoLei1990
reviewed
Apr 2, 2024
GuoLei1990
approved these changes
Apr 2, 2024
GuoLei1990
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Fix #2047
The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
Support texture
grad
,proj
etc functionSupport
gl_FragDepthEXT
when use glslES 1.00Fix fragment out written use glslES 1.00