Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GLSL ES3.00 shader syntax compatibility #2048

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

zhuxudong
Copy link
Member

@zhuxudong zhuxudong commented Mar 25, 2024

Please check if the PR fulfills these requirements

Fix #2047

  • The commit message follows our guidelines

  • Tests for the changes have been added (for bug fixes / features)

  • Docs have been added / updated (for bug fixes / features)

  • Support texture grad,proj etc function

  • Support gl_FragDepthEXT when use glslES 1.00

  • Fix fragment out written use glslES 1.00

@zhuxudong zhuxudong self-assigned this Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.10%. Comparing base (6c06394) to head (09dea9d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2048      +/-   ##
==========================================
+ Coverage   66.05%   66.10%   +0.05%     
==========================================
  Files         460      460              
  Lines       22996    23000       +4     
  Branches     3369     3369              
==========================================
+ Hits        15190    15205      +15     
+ Misses       6645     6631      -14     
- Partials     1161     1164       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@GuoLei1990 GuoLei1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit test

@GuoLei1990
Copy link
Member

Completed supplementary inspection:
image

@GuoLei1990
Copy link
Member

image
Babylon.js don't have this bug

@GuoLei1990 GuoLei1990 added shader Shader related functions bug Something isn't working labels Apr 2, 2024
@GuoLei1990 GuoLei1990 changed the title Ignore convert to 300 if original shader is glsl300 Fix convert to glslES 3.00 bug Apr 2, 2024
@GuoLei1990 GuoLei1990 changed the title Fix convert to glslES 3.00 bug Improve glslES3.00 shader syntax compatibility Apr 2, 2024
@GuoLei1990 GuoLei1990 merged commit 9bc4370 into galacean:main Apr 2, 2024
8 checks passed
@GuoLei1990 GuoLei1990 requested a review from Sway007 April 2, 2024 08:00
@GuoLei1990 GuoLei1990 changed the title Improve glslES3.00 shader syntax compatibility Improve GLSL ES3.00 shader syntax compatibility Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shader Shader related functions
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

glsl compile error with GLSL ES 3.00
3 participants