Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url resolve error #2049

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Fix url resolve error #2049

merged 3 commits into from
Apr 1, 2024

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Mar 27, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.07%. Comparing base (6c06394) to head (7b126ce).

Files Patch % Lines
packages/core/src/Utils.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2049      +/-   ##
==========================================
+ Coverage   66.05%   66.07%   +0.02%     
==========================================
  Files         460      460              
  Lines       22996    22992       -4     
  Branches     3369     3367       -2     
==========================================
+ Hits        15190    15193       +3     
+ Misses       6645     6639       -6     
+ Partials     1161     1160       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 added bug Something isn't working resource Resource-related functions labels Apr 1, 2024
@GuoLei1990 GuoLei1990 merged commit 2d08e44 into galacean:main Apr 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resource Resource-related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants