Fix background textureFillMode missed of SceneLoader

[zhuxudong]

https://github.com/galacean/editor/pull/2717

Summary by CodeRabbit

• New Features
  • Enhanced scene background customization by adding support for textureFillMode.

[GuoLei1990]

@coderabbitai review

[coderabbitai]

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Warning

Review failed

The pull request is closed.

Walkthrough

The overall changes focus on updating the SceneLoader and SceneSchema components to incorporate the textureFillMode property for scene backgrounds. This update ensures that the BackgroundTextureFillMode is imported and utilized within the SceneLoader class, setting it conditionally if available.

Changes

File(s)	Change Summary
packages/loader/src/SceneLoader.ts	Assigned textureFillMode to background.textureFillMode if defined, using a conditional check.
`packages/loader/src/resource-deserialize/resources/schema/...	Updated import to include BackgroundTextureFillMode and added textureFillMode to IBackground

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SceneLoader
    participant Scene
    participant Background

    User->>SceneLoader: Load Scene
    SceneLoader->>Scene: Initialize Scene with Background
    SceneLoader-->>Scene: Set background.textureFillMode if defined
    Scene->>Background: Apply textureFillMode

Loading

Poem

By moonlit code and daytime byte,
The background now fills just right,
With texture modes both near and far,
It paints the scene, a rising star.
In schemas deep and loaders, clean,
We crafted well a wondrous scene.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.