Clamp linear gamma at last output

[zhuxudong]

Please check if the PR fulfills these requirements

delete it when support sRGB

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

• Refactor
  • Improved linearToGamma function to ensure input values are clamped, enhancing stability.
  • Simplified envBRDFApprox function for better performance and clarity.

[coderabbitai]

Walkthrough

The recent changes introduce modifications to the GLSL shader files. The linearToGamma function now ensures the input vector is clamped to a minimum of 0.0, enhancing stability. Meanwhile, in the envBRDFApprox function, a conditional check was removed, which may affect its return value under specific conditions, simplifying the code logic.

Changes

Files	Change Summary
packages/core/src/shaderlib/common.glsl	Added a clamp to the linearToGamma function to ensure the linearIn vector is at least 0.0.
packages/core/src/shaderlib/pbr/ibl_frag_define.glsl	Removed a conditional check from the envBRDFApprox function, simplifying the return statement.

Poem

In the realm where shaders gleam and glow,
A rabbit tweaks the code to flow.
With clamp and check now out the door,
Our graphics shine like never before! 🌟
Hopping through the lines, so spry and quick,
Making magic with each flick. 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f5dc3bd and 0a1a6e3.

Files selected for processing (2)

• packages/core/src/shaderlib/common.glsl (1 hunks)
• packages/core/src/shaderlib/pbr/ibl_frag_define.glsl (1 hunks)

Additional comments not posted (8)

packages/core/src/shaderlib/pbr/ibl_frag_define.glsl (2)

Line range hint 1-13:
LGTM!

The getLightProbeIrradiance function is well-implemented and has no changes in this PR.

---

35-37: Verify the impact of the conditional check removal.

The conditional check removal simplifies the return statement but may affect the function's behavior under specific input conditions.

packages/core/src/shaderlib/common.glsl (6)

Line range hint 8-9:
LGTM!

The pow2 function is well-implemented and has no changes in this PR.

---

Line range hint 11-13:
LGTM!

The RGBMToLinear function is well-implemented and has no changes in this PR.

---

Line range hint 15-17:
LGTM!

The gammaToLinear function is well-implemented and has no changes in this PR.

---

19-21: LGTM!

The addition of the clamping line in the linearToGamma function enhances stability by ensuring that the linearIn vector does not have negative values.

---

Line range hint 23-25:
LGTM!

The remapDepthBufferLinear01 function is well-implemented and has no changes in this PR.

---

Line range hint 28-83:
LGTM!

The matrix inversion functions are well-implemented and have no changes in this PR.