Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBR support sheen #2448

Merged
merged 5 commits into from
Dec 12, 2024

fix: sheen

5604310
Select commit
Loading
Failed to load commit list.
Merged

PBR support sheen #2448

fix: sheen
5604310
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 11, 2024 in 0s

50.78% of diff hit (target 67.12%)

View this Pull Request on Codecov

50.78% of diff hit (target 67.12%)

Annotations

Check warning on line 244 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L240-L244

Added lines #L240 - L244 were not covered by tests

Check warning on line 252 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L251-L252

Added lines #L251 - L252 were not covered by tests

Check warning on line 256 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L255-L256

Added lines #L255 - L256 were not covered by tests

Check warning on line 263 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L262-L263

Added lines #L262 - L263 were not covered by tests

Check warning on line 272 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L266-L272

Added lines #L266 - L272 were not covered by tests

Check warning on line 280 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L279-L280

Added lines #L279 - L280 were not covered by tests

Check warning on line 289 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L283-L289

Added lines #L283 - L289 were not covered by tests

Check warning on line 323 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L317-L323

Added lines #L317 - L323 were not covered by tests

Check warning on line 40 in packages/loader/src/gltf/extensions/KHR_materials_sheen.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/loader/src/gltf/extensions/KHR_materials_sheen.ts#L12-L40

Added lines #L12 - L40 were not covered by tests