Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PBR support sheen #2448
PBR support sheen #2448
Changes from 1 commit
06a4242
d1dda0c
5604310
313db93
affd513
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 237 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L236-L237
Check warning on line 248 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L240-L248
Check warning on line 256 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L255-L256
Check warning on line 263 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L259-L263
Check warning on line 271 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L270-L271
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe should add
value = Math.max(0, Math.min(1, value));
if you want clamp the range like commentsCheck warning on line 275 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L274-L275
Check warning on line 282 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L281-L282
Check warning on line 291 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L285-L291
Check warning on line 298 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L297-L298
Check warning on line 307 in packages/core/src/material/PBRMaterial.ts
packages/core/src/material/PBRMaterial.ts#L301-L307
Check warning on line 40 in packages/loader/src/gltf/extensions/KHR_materials_sheen.ts
packages/loader/src/gltf/extensions/KHR_materials_sheen.ts#L12-L40