fix: delete default gl state #550

zhuxudong · 2021-10-23T02:34:52Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

#503

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

codecov-commenter · 2021-10-23T02:41:00Z

Codecov Report

Merging #550 (a13e18e) into main (3b4a242) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   48.10%   48.10%           
=======================================
  Files         349      349           
  Lines       18974    18974           
  Branches     2549     2547    -2     
=======================================
  Hits         9127     9127           
  Misses       9847     9847

Impacted Files	Coverage Δ
packages/rhi-webgl/src/WebGLRenderer.ts	`76.55% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4a242...a13e18e. Read the comment docs.

singlecoder · 2021-10-23T02:50:19Z

packages/rhi-webgl/src/WebGLRenderer.ts

-  private _lastViewport: Vector4 = new Vector4(undefined, undefined, undefined, undefined);
-  private _lastClearColor: Color = new Color(undefined, undefined, undefined, undefined);
+  private _lastViewport: Vector4 = new Vector4(null, null, null, null);
+  private _lastClearColor: Color = new Color(null, null, null, null);


like this
new Color(0, 0, 0, 0)

GuoLei1990

+1

* feat: solve math design circular dependency (#485) * feat: solve math design cirular dependency * Revert "feat: solve math design circular dependency (#485)" (#487) This reverts commit df25f03. * feat: add rotateAxisAngle for Quaternion (#480) * feat: add rotateAxisAngle for Quaternion * refactor: delete useless scene raycast (#493) * fix: group other uniform block (#504) * fix(primitivemesh): fix cylinder error (#526) * Perf: release gpu command (#503) * perf: release viewport gpu command * perf: release clearColor gpu command * fix: reset clipTime (#530) * fix: reset clipTime * fix: use string replace asset type to extend easily (#520) * Fix/animator (#531) * fix: animator bug * Update README.md * Fix: cubic interpolation and crossfade bug: From fixed pose to dest pose, throw error. (#534) * fix: Animator bug * v0.5.3 * v0.5.4 * v0.5.5 * v0.5.6 * fix(2d): opt shader precision (#542) * fix: delete default gl state (#550) Co-authored-by: shensi.zxd <shensi.zxd@alibaba-inc.com> * fix(gl): fix gl error (#555) * v0.5.7 * Fix Call EndRender Error (#563) * fix: onEndRender trigger error * feat: support skybox with hdr(rgbe) format (#567) * feat: add rgbm decode mode * fix: color space correction (#566) * fix: color space correction * fix: bump version (#568) * feat: change clipTime to normalized as same as transitionTime for mo… (#560) * feat: change clipTime to normalized as same as transitionTime for more understandable * Update README.md * Update README.md * Update README.md * feat: add method: addEvent overload (#559) * feat: support ambient-light replacement (#569) * feat: support ambient-light replacement Co-authored-by: shensi.zxd <shensi.zxd@alibaba-inc.com> Co-authored-by: GuoLei <gl3336563@163.com> * Feat/ambient light adapter editor (#570) * feat: adapter oasis editor with ambient light * feat: add getCurrentAnimatorState API and fix crossfade time (#565) * fix: use alipay cdn for physx wasm (#571) * add wasm file (#572) * fix: use alipay cdn for physx wasm * fix: include wasm files * Fix : the compatibility problem of IOS lower version (#573) * fix: the compatibility problem of IOS lower version * Merge dev/0.6 branch (#574) * feat: solve math design circular dependency (#488) * feat: solve math design cirular dependency * PhysX based raycast and collider (#505) * feat: add physx version raycast and trigger * feat: add trigger event in script * feat: Add InputManager (#497) * feat: add InputManager * Fix InputManager's Bug which will be triggered when there is no physics engine. (#524) * fix:InputManager modify timing * Lite Physics Package (#522) * feat: add physics lite package * Refactor: split pbr shader (#514) * refactor: pbr shader clean up * feat: add createCapsule in PrimitiveMesh (#515) * feat: add createCapsule in PrimitiveMesh * Feat: support read/write mipmap data from textures and render target (#382) * feat: support render to mip level * feat: support reading from texture with mip level * Feat: hdr runtime (#523) * feat: support IBL HDR Specular * perf: plane horizontal default (#535) * perf(plane): plane horizontal default * fix(plane): fix cull face (#537) * fix(plane): fix uv error (#538) * feat: add more uv channel and color (#548) * Feat: Sprite add clone function. (#532) * feat: sprite add clone function * Add color space (#543) * feat: add engine settings * fix: opt code (#519) * feat: modify physics-related class for editor (#547) * feat: modify physics-related class for editor * Merge main to dev/0.6 (#553) * refactor: merge main to dev/0.6 * fix: bump verison (#557) Co-authored-by: shensi.zxd <shensi.zxd@alibaba-inc.com> * fix: shader error (#556) Co-authored-by: shensi.zxd <shensi.zxd@alibaba-inc.com> * feat/add AnimatorState script for handle animatorState's lifecycle (#552) * feat: add `StateMachineScript` * feat: support skybox with hdr(rgbe) format (#567) * feat: add rgbm decode mode * fix: color space correction (#566) * fix: color space correction * fix: bump version (#568) * feat: change clipTime to normalized as same as transitionTime for mo… (#560) * feat: change clipTime to normalized as same as transitionTime for more understandable * feat: add method: addEvent overload (#559) * feat: support ambient-light replacement (#569) * feat: support ambient-light replacement Co-authored-by: shensi.zxd <shensi.zxd@alibaba-inc.com> Co-authored-by: GuoLei <gl3336563@163.com> * Feat/ambient light adapter editor (#570) * feat: adapter oasis editor with ambient light * feat: add getCurrentAnimatorState API and fix crossfade time (#565) * fix: use alipay cdn for physx wasm (#571) * add wasm file (#572) * fix: use alipay cdn for physx wasm * fix: include wasm files * Fix : the compatibility problem of IOS lower version (#573) * fix: the compatibility problem of IOS lower version Co-authored-by: yangfengzzz <yangfengzzz@hotmail.com> Co-authored-by: AZhan <njktsmshh@163.com> Co-authored-by: zhuxudong <callzhuxudong@163.com> Co-authored-by: JujieX <67930474+JujieX@users.noreply.github.com> Co-authored-by: singlecoder <singlecoder2014@gmail.com> Co-authored-by: shensi.zxd <shensi.zxd@alibaba-inc.com> Co-authored-by: luzhuang <364439895@qq.com> * v0.6.0-alpha.0 * refactor: fix physics package.json * refactor: fix physics package.json (#575) * v0.6.0-alpha.1 Co-authored-by: yangfengzzz <yangfengzzz@hotmail.com> Co-authored-by: JujieX <67930474+JujieX@users.noreply.github.com> Co-authored-by: Hu Song <gz65555@gmail.com> Co-authored-by: zhuxudong <callzhuxudong@163.com> Co-authored-by: singlecoder <singlecoder2014@gmail.com> Co-authored-by: luzhuang <364439895@qq.com> Co-authored-by: Bob <768442443@qq.com> Co-authored-by: shensi.zxd <shensi.zxd@alibaba-inc.com> Co-authored-by: AZhan <njktsmshh@163.com>

Co-authored-by: shensi.zxd <shensi.zxd@alibaba-inc.com>

fix: delete default gl state

a13e18e

zhuxudong added the bug Something isn't working label Oct 23, 2021

zhuxudong requested review from GuoLei1990, singlecoder and cptbtptpbcptdtptp October 23, 2021 02:34

zhuxudong self-assigned this Oct 23, 2021

singlecoder reviewed Oct 23, 2021

View reviewed changes

cptbtptpbcptdtptp linked an issue Oct 23, 2021 that may be closed by this pull request

scene.background.solidColor.setValue(1, 1, 1, 1) 竟然是黑色背景，大为震撼 #549

Closed

GuoLei1990 approved these changes Oct 25, 2021

View reviewed changes

GuoLei1990 merged commit e36cb48 into galacean:main Oct 25, 2021

luzhuang pushed a commit to luzhuang/engine that referenced this pull request Sep 6, 2022

fix: delete default gl state (galacean#550)

2b070b0

Co-authored-by: shensi.zxd <shensi.zxd@alibaba-inc.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: delete default gl state #550

fix: delete default gl state #550

zhuxudong commented Oct 23, 2021

codecov-commenter commented Oct 23, 2021 •

edited

Loading

singlecoder Oct 23, 2021

GuoLei1990 left a comment

fix: delete default gl state #550

fix: delete default gl state #550

Conversation

zhuxudong commented Oct 23, 2021

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

codecov-commenter commented Oct 23, 2021 • edited Loading

Codecov Report

singlecoder Oct 23, 2021

Choose a reason for hiding this comment

GuoLei1990 left a comment

Choose a reason for hiding this comment

codecov-commenter commented Oct 23, 2021 •

edited

Loading