chore: v0.9.38 #194
chore: v0.9.38 #194
Conversation
fix(nft): associated types in `InspectEnumerable` trait
feat(duster): default storage version
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 73.96% 73.91% -0.06%
==========================================
Files 45 45
Lines 3607 3615 +8
==========================================
+ Hits 2668 2672 +4
- Misses 939 943 +4
☔ View full report in Codecov by Sentry. |
Roznovjak
requested review from
martinfridrich,
mrq1911,
jak-pan,
apopiak and
dmoka
|
we should make sure to include #206 (just merged) |
| @@ -19,7 +19,6 @@ use crate::Config; | |||
| use frame_support::weights::Weight; | |||
| use sp_std::vec::Vec; | |||
|
|
|||
| /// Storage names are changed from Classes to Collections and from Instances to Items. | |||
| pub mod v1 { | |||
There was a problem hiding this comment.
do we still need this migration at all?
There was a problem hiding this comment.
Yes, based on the storage version in Basilisk and Hydra, we will need it.
| @@ -233,6 +237,7 @@ pub mod pallet { | |||
| /// Parameters: | |||
| /// - `origin`: The collection owner. | |||
| /// - `collection_id`: The identifier of the asset collection to be destroyed. | |||
| #[pallet::call_index(4)] | |||
There was a problem hiding this comment.
Did you check that the call index is set to the same index as it was before? it seems like it does out by my random checks, but I didn't check every single one. seems like pattern is ok
There was a problem hiding this comment.
No, but based on my assumption and this comment indexes are assigned sequentially and in order.
| @@ -75,7 +75,7 @@ fn create_collection_works() { | |||
| // reserved collection ID | |||
| assert_noop!( | |||
| NFTPallet::create_collection( | |||
| Origin::signed(ALICE), | |||
| RuntimeOrigin::signed(ALICE), | |||
There was a problem hiding this comment.
Why was Origin renamed to RuntimeOrigin and Event to RuntimeEvent?
There was a problem hiding this comment.
IMHO to differentiate outer enums that are created by construct_runtime macro from nested enums from pallets.
You can see it in this example:
RuntimeCall::Balances(pallet_balances::Call::transfer { dest: ALICE, value: 10 })
based on #174.
Notable changes:
sudo apt-get install protobuf-compiler
sudo apt-get install m4
#[pallet::call_index(0)]
OnDust trait move into submodule called currency
InspectEnumerable trait changed - needs closer look to verify f reimplemented correcy.
check if changes in orml currencies to ensure no bugs fixed ?
callbacks OnDust,OnNewAccoutn and OnKilledAccount combined into one CurrencyHooks.