Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supress usage text from cobra #184

Merged
merged 3 commits into from
Dec 5, 2023
Merged

supress usage text from cobra #184

merged 3 commits into from
Dec 5, 2023

Conversation

techcobweb
Copy link
Contributor

@techcobweb techcobweb commented Dec 5, 2023 •
edited
Loading

Signed-off-by: Mike Cobbett 77053+techcobweb@users.noreply.github.com

Tackling issue Defect: CLI - Cobra commands print out error twice and disoplays help menu#1677

  • Cobra commands don't now always display usage when our code returns an error back to cobra.
  • The cobra framework displays the error with 'Error - ' at the front, rather than us displaying it. Not idea I know, but the best we can do I think.

@techcobweb
supress usage text from cobra
5c1d8ed 
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@techcobweb
restore some removed unit test assertions
f3e9eb0 
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@techcobweb
merge main into this branch to resolve conflicts
c2bfd21 
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@galasa-team
Copy link

Build successful

@techcobweb techcobweb merged commit 5bfdcae into main Dec 5, 2023
2 checks passed
@techcobweb techcobweb deleted the mcobbett-supress-double-error-reporting branch December 5, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadecarino jadecarino jadecarino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@techcobweb @galasa-team @jadecarino