Copernicus marine minor fix AND .... #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marie59
changed the title
|
Apparently there's still the same github security issue |
|
@Marie59 you need to create for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I noticed some really minor fixes to make while testing the tool
BUT I also noticed it's not working ... It seems that even thought I put my credentials in my preferences it's not getting them.
#set $cmems_username = $__user__.extra_preferences.get('cmems_username', "") #set $cmems_password = $__user__.extra_preferences.get('cmems_password', "")I guess there is something not working there. Not sure but could it be that this cmems_username and cmems_password should be in capital ?
Do you have the PR of when this was implemented into the Galaxy preference user so I can have a look at it ?