Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ancillary config files are incorrectly configured by default #168

Open
pvanheus opened this issue Aug 31, 2022 · 2 comments
Open

Ancillary config files are incorrectly configured by default #168

pvanheus opened this issue Aug 31, 2022 · 2 comments

Comments

@pvanheus
Copy link
Contributor

The changes to how job metrics, dependency resolvers and container resolvers are configured introduced by #133 result in incorrect config in the default case.

What I mean by that is that if, for example, I do not set the galaxy_job_metrics_plugins variable, I get a line in my galaxy.yml like:

job_metrics_config_file: /galaxy_dir/config/job_metrics.conf.xml

and then /galaxy_dir/config/job_metrics.conf.xml is non-existent with the result that Galaxy will now start up with no job metrics config whatsoever, possibly triggering this bug: galaxyproject/galaxy#14557

@pvanheus pvanheus changed the title ancillary config files are incorrectly configured by default Ancillary config files are incorrectly configured by default Aug 31, 2022
@natefoo
Copy link
Member

natefoo commented Aug 31, 2022

Also worth noting that Galaxy in its default configuration would load the core plugin, and this I believe prevents that.

@pvanheus
Copy link
Contributor Author

pvanheus commented Sep 1, 2022

Also worth noting that Galaxy in its default configuration would load the core plugin, and this I believe prevents that.

Exactly. So the behaviour that is wanted is that:

  1. if the user sets galaxy_job_metrics_plugins a yaml file is generated with the appropriate configuration.
  2. if the user sets job_metrics_config_file in their galaxy_config then that value is respected (I think that this should already be the case because the issue noted above impacts the Ansible defaults.
  3. if the user sets neither, the job_metrics_config_file is either not set (preferable) or points to a sample config that maintains the Galaxy default behaviour. I'm not sure how to do this in Ansible - one might need conditionally set config variables that get merged into a final set of defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants