Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static files are not updated when using galaxy_manage_subdomain_static #213

Closed
mira-miracoli opened this issue May 2, 2024 · 2 comments · Fixed by #215
Closed

Static files are not updated when using galaxy_manage_subdomain_static #213

mira-miracoli opened this issue May 2, 2024 · 2 comments · Fixed by #215

Comments

@mira-miracoli
Copy link
Collaborator

mira-miracoli commented May 2, 2024

After we upgraded EU to 24.0, we noticed, that some subdomains were having old CSS files.
see (not public):

This comes potentially from the ignore_existing flag I set to rsync the files from Galaxy's default static directory to the subdomain's static directory. The reason was, that ansible would touch files that are different for the subdomain on every plabook run. It would first overwrite them with the rsync command and than overwrite them again when it copies over subdomain's custom file.
My idea to solve this would be using this:
{{ __galaxy_client_build_version }} != {{ __galaxy_current_commit_id }}
as indicator that Galaxy has been updated and in that case omit the ignore_existing flag. Does that sound sensible to you
@hexylena @natefoo or do you think there is a better approach?

@mira-miracoli
Copy link
Collaborator Author

@natefoo @hexylena any Ideas? maybe we can discuss it at GCC :)

@hexylena
Copy link
Member

sounds good, let's discuss then since I'm quite busy until then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants