Fix mypy errors

galaxyproject · Oct 25, 2024 · 9929a46 · 9929a46
1 parent c9b6d97
commit 9929a46
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/galaxy/managers/roles.py b/lib/galaxy/managers/roles.py
@@ -84,7 +84,11 @@ def create_role(self, trans: ProvidesUserContext, role_definition_model: RoleDef
         user_ids = role_definition_model.user_ids or []
         group_ids = role_definition_model.group_ids or []
 
-        stmt = select(Role).where(Role.name == name).limit(1)
+        stmt = (
+            select(Role)
+            .where(Role.name == name)  # type:ignore[arg-type,comparison-overlap]  # Role.name is a SA hybrid property
+            .limit(1)
+        )
         if trans.sa_session.scalars(stmt).first():
             raise Conflict(f"A role with that name already exists [{name}]")
 

diff --git a/lib/galaxy/model/__init__.py b/lib/galaxy/model/__init__.py
@@ -3776,7 +3776,7 @@ def name(self):
         else:
             return self._name
 
-    @name.setter
+    @name.setter  # type:ignore[no-redef]  # property setter
     def name(self, name):
         self._name = name