User-facing objectstore metadata. #10233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
data_inspector
branch
2 times, most recently
from
5be378d
to
311ad5e
Compare
jmchilton
force-pushed
the
data_inspector
branch
from
311ad5e
to
32b20ec
Compare
jmchilton
changed the title
jmchilton
force-pushed
the
data_inspector
branch
from
32b20ec
to
3d9934d
Compare
mvdbeek
reviewed
Oct 7, 2020
| This data is stored in a Galaxy ObjectStore named <b>{{ storageInfo.name }}</b | ||
| >. | ||
| </p> | ||
| <p v-if="storageInfo.object_store_id"> |
There was a problem hiding this comment.
If both name and id are defined this seems to take up more screen space than needed, maybe you could combine that into one sentence (or a small table?)?
There was a problem hiding this comment.
This was mean t to be an else-if I think. Thanks for the catch!
jmchilton
force-pushed
the
data_inspector
branch
from
3d9934d
to
be09996
Compare
This was referenced Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6552 implemented the ability for admins to assign job outputs to different object stores at runtime and #10221 implements the ability to assign quotas and perform tracking for different object stores and groups of object stores. So for instance, user preferences or injected tool resource parameters can be used to create files in different object stores and disk usage and quota limits will be tracked and can be used in that calculation.
Still the user has no way of knowing what data went where or what that means for their analysis. Beyond this retrospective use case, as we look forward to user-based selections - we are not currently tracking metadata that might help a user make selections about which object store to use. This PR adds the ability for admins to annotate objectstores with more metadata - enough to solve this first problem and provide some infrastructure for solving that selection problem in the future.
Concrete ObjectStores (defined in either XML or YAML) can now be named and can have a rich Markdown description. A dataset API endpoint has been added that exposes this metadata for a particular existing dataset and this information will now be rendered as part of the dataset info page.
Here are two examples - illustrating how admins might highlight long term, backed up storage and short term scratch storage. They also demonstrate the power of allowing admins to define these annotations using Markdown.
Long Term Storage:
Short Term Storage: