Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21.09] Fix private history publishing #13056

Merged
merged 2 commits into from
Dec 14, 2021
Merged

[21.09] Fix private history publishing #13056

merged 2 commits into from
Dec 14, 2021

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Dec 13, 2021 •
edited
Loading

Fixes #13001

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    • Share a history containing private datasets (that you own) by making it accessible via link or publishing it
    • Other users can access the private datasets

License

@davelopez davelopez marked this pull request as ready for review December 14, 2021 09:27
@github-actions github-actions bot added this to the 22.01 milestone Dec 14, 2021
@mvdbeek mvdbeek merged commit 799a94f into galaxyproject:release_21.09 Dec 14, 2021
@mvdbeek
Copy link
Member

mvdbeek commented Dec 14, 2021

Thank you @davelopez!

@davelopez davelopez deleted the fix_private_history_publishing branch December 14, 2021 15:34
@hexylena
Copy link
Member

Thank you so much @davelopez!! This is very helpful. @gmauro @bgruening could you update EU to include this?

@hexylena hexylena mentioned this pull request Dec 14, 2021
Closed
@gmauro
Copy link
Member

gmauro commented Dec 14, 2021

will be deployed tonight on .eu

@hexylena
Copy link
Member

amazing, thank you @gmauro!

davelopez added a commit to davelopez/galaxy that referenced this pull request Dec 14, 2021
@davelopez
Adapt API test to expect 403 status code
f1bccc6 
After aplying the fix galaxyproject#13056, `test_sharing_private_history_makes_datasets_public` will now return a proper 403 status code instead of 400.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/histories area/sharing kind/bug
Projects
None yet
Milestone
22.01
Development

Successfully merging this pull request may close these issues.
4 participants
@davelopez @mvdbeek @hexylena @gmauro