[22.01] Revert startswith of tool parameter options

[qiagu]

I think the previous change broke the startswith.
ping @bernt-matthias

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these contributions under Galaxy's current license.
• I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to galaxy-committers@lists.galaxyproject.org.

[bernt-matthias]

Hi @qiagu. The previous change indeed changed the behavior.. but it brought it in line with the documented behavior.

See details in #14332

Or am I wrong?

[bernt-matthias]

You are right @qiagu

The wrong docs is due to cc23b0e that was included in a PR crafted by you and me :)

So the code needs to be reverted, but docs and tests need fixes.

[bernt-matthias]

Can you target the 22.01 branch?

[qiagu]

I guess we want to use the lines with startswith instead of skipping them. Sorry for documentation issue.

[bernt-matthias]

Sorry for documentation issue.

No worries. The commit was by me :)

[bgruening]

FAILED test/functional/test_toolbox_pytest.py::test_tool[select_from_csvdataset_test_1]

I think the test failure looks legitimate.

[anuprulez]

I tested this change on this branch: release_22.05_europe (https://github.com/usegalaxy-eu/galaxy) and unfortunately I could not make it work with hyperparameter search tool with option startswith="@". But, when I removed not from this change and used startswith="*", the tunable params in a list populated inside hyperparameter search tool gets correctly loaded. I am not sure if the option startswith is used to include or exclude text starting with the specified parameter. The tabular file has both, * and @ present in the beginning of the file.

[bernt-matthias]

startswith="@" should keep only the lines that start with @

[qiagu]

@bernt-matthias I wonder whether you would like to do the rest. I imagine the remaining work includes fixing tests and docs. Thanks.