Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the 440 version linter an error #15962

Closed

Conversation

bernt-matthias
Copy link
Contributor

xref #15945 (comment)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton
Copy link
Member

The tool loads - this should be a warning as I originally defined them. We keep getting bit by the tools-iuc not blocking PRs on warning but that isn't a reason to change warnings to errors.

@bernt-matthias
Copy link
Contributor Author

The tool loads - this should be a warning

Thanks for the feedback. fine for me :)

as I originally defined them

could you point me to the docs?

We keep getting bit by the tools-iuc not blocking PRs on warning

OK. I will open a PR changing the workflow accordingly.

@bernt-matthias bernt-matthias deleted the topic/lint-440-error branch April 19, 2023 18:19
bernt-matthias added a commit to bernt-matthias/tools-iuc that referenced this pull request Apr 19, 2023
bernt-matthias added a commit to bernt-matthias/tools-iuc that referenced this pull request Apr 19, 2023
@nsoranzo
Copy link
Member

The tool loads - this should be a warning as I originally defined them. We keep getting bit by the tools-iuc not blocking PRs on warning but that isn't a reason to change warnings to errors.

It does load, but it's in the wrong place in the tool lineage, which I'd say it's an error not a warning.

@bernt-matthias bernt-matthias restored the topic/lint-440-error branch April 20, 2023 09:10
@bernt-matthias
Copy link
Contributor Author

The tool loads - this should be a warning as I originally defined them.

Then lets either add this PR or tighten the definition and doc of what an error / warning is

@mvdbeek mvdbeek marked this pull request as draft June 21, 2023 19:11
@mvdbeek mvdbeek removed this from the 23.1 milestone Jun 21, 2023
@bernt-matthias
Copy link
Contributor Author

IUC fails now on warn. So I'm happy. 😎

TomHarrop pushed a commit to TomHarrop/galaxy-local-tools that referenced this pull request Aug 28, 2023
TomHarrop pushed a commit to TomHarrop/galaxy-local-tools that referenced this pull request Aug 28, 2023
TomHarrop pushed a commit to TomHarrop/galaxy-local-tools that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants