Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Fix dataype_change not updating HDCA update_time #16099

Merged
merged 2 commits into from
May 17, 2023
Merged

[23.0] Fix dataype_change not updating HDCA update_time #16099

merged 2 commits into from
May 17, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 16, 2023

That update_time is used to find changed items in the history

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Fix dataype_change not updating HDCA update_time
12eca28 
That update_time is used to find changed items in the history
@github-actions github-actions bot added area/database Galaxy's database or data access layer area/testing area/testing/api labels May 16, 2023
@github-actions github-actions bot added this to the 23.0 milestone May 16, 2023
@mvdbeek mvdbeek mentioned this pull request May 16, 2023
Merged
2 tasks
@nsoranzo
Copy link
Member

nsoranzo commented May 17, 2023 •
edited
Loading

The test_galaxy_packages failures are due to sqlalchemy/alembic#1243 .

@mvdbeek
Copy link
Member Author

mvdbeek commented May 17, 2023

We should probably still use the kwarg version, I can open a PR for that.

@nsoranzo
Copy link
Member

Agreed, I am testing a fix right now, then I'll open the PR.

@mvdbeek
Copy link
Member Author

mvdbeek commented May 17, 2023

awesome, thank you!

@nsoranzo nsoranzo mentioned this pull request May 17, 2023
Merged
2 tasks
@jmchilton jmchilton merged commit 22a9029 into galaxyproject:release_23.0 May 17, 2023
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo deleted the fix_hdca_update_time branch May 17, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo left review comments

Assignees
No one assigned
Labels
area/database Galaxy's database or data access layer area/testing/api area/testing kind/bug
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mvdbeek @nsoranzo @jmchilton