Optional Reply-to SMTP header in tool error reports #17243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/documentation
area/admin
area/tool-framework
area/util
labels
mvdbeek
reviewed
Jan 8, 2024
lib/galaxy/util/__init__.py
Outdated
| @@ -1551,6 +1554,9 @@ def send_mail(frm, to, subject, body, config, html=None): | |||
| msg.attach(mp_text) | |||
| msg.attach(mp_html) | |||
|
|
|||
| if reply_to: | |||
There was a problem hiding this comment.
Does it ever make sense not to do this ? I'd be in favor of not making this configurable
There was a problem hiding this comment.
I would say not - people can just choose to ignore the header in downstream applications. And if not, I can't see them ever wanting to reply to their Galaxy server.
There was a problem hiding this comment.
@mvdbeek I have removed configuration
mvdbeek
approved these changes
Jan 8, 2024
|
Thank you @neoformit! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16248.
error_email_reply_to_user <bool>true, tool error emails will have SMTPReply-toheader set touser.emailLicense