Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Pin ubuntu 22.04 for minikube setup action #18965

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 9, 2024

The ubuntu-latest runner label is moving to 24.04, see https://github.blog/changelog/2024-09-25-actions-new-images-and-ubuntu-latest-changes/

Fixes https://github.com/galaxyproject/galaxy/actions/runs/11260477825/job/31317049837?pr=18963:

No VM guests are running outdated hypervisor (qemu) binaries on this host.
/usr/bin/lsb_release --short --codename
noble
Error: Unexpected HTTP response: 404

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

The `ubuntu-latest` runner label is moving to 24.04, see https://github.blog/changelog/2024-09-25-actions-new-images-and-ubuntu-latest-changes/

Fixes https://github.com/galaxyproject/galaxy/actions/runs/11260477825/job/31317049837?pr=18963:
```
No VM guests are running outdated hypervisor (qemu) binaries on this host.
/usr/bin/lsb_release --short --codename
noble
Error: Unexpected HTTP response: 404
```
@github-actions github-actions bot added this to the 24.1 milestone Oct 9, 2024
@nsoranzo
Copy link
Member

nsoranzo commented Oct 9, 2024

By looking at the medyagh/setup-minikube action source, the error happens when it tries to download a cri-dockerd 0.3.1 deb package, which doesn't exist for Ubuntu 24.04 "noble".
Actually there isn't a deb package for 24.04 even for the latest cri-dockerd version, see Mirantis/cri-dockerd#361

@mvdbeek
Copy link
Member Author

mvdbeek commented Oct 10, 2024

That'll likely be updated in the future, no need to worry about this now ?

@davelopez
Copy link
Contributor

Should we do the same for test_galaxy_packages_for_pulsar?

@nsoranzo
Copy link
Member

Should we do the same for test_galaxy_packages_for_pulsar?

#18959

@nsoranzo
Copy link
Member

That'll likely be updated in the future, no need to worry about this now ?

Sure. After doing some investigation on why this was failing (No VM guests are running outdated hypervisor (qemu) binaries on this host is a completely unrelated warning), I simply wanted to document it somewhere in case we want to open an issue on https://github.com/medyagh/setup-minikube/

@nsoranzo nsoranzo merged commit 1cbfbc8 into galaxyproject:release_24.1 Oct 10, 2024
45 of 48 checks passed
@nsoranzo nsoranzo deleted the pin_ubuntu_22_4_for_minikube_setup_error branch October 10, 2024 10:28
@nsoranzo
Copy link
Member

Sure. After doing some investigation on why this was failing (No VM guests are running outdated hypervisor (qemu) binaries on this host is a completely unrelated warning), I simply wanted to document it somewhere in case we want to open an issue on https://github.com/medyagh/setup-minikube/

medyagh/setup-minikube#565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants