-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run installed Galaxy with no config and a simplified entry point #19050
base: dev
Are you sure you want to change the base?
Conversation
6e85873
to
23b9aa3
Compare
23b9aa3
to
90caa40
Compare
the non-sample is not present, and for installed Galaxy. Fix robots.txt and favicon which were not served at all due to middleware.
This is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Although I didn't test the install locally.
@@ -386,7 +386,8 @@ mapping: | |||
required: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the default from the line above like we do for managed_config_dir
and data_dir
.
if not running_from_source and kwargs.get("conda_auto_init") is None: | ||
self.config_dict["conda_auto_init"] = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not running_from_source and kwargs.get("conda_auto_init") is None: | |
self.config_dict["conda_auto_init"] = False | |
if kwargs.get("conda_auto_init") is None: | |
self.config_dict["conda_auto_init"] = running_from_source |
Building off #17102, make it possible to start and run a simple Galaxy web server using a single command when running from installed packages and the prebuilt client. Also
delays conda auto-init util the first time an install is attempted.disables conda auto-init when running installed.How to test the changes?
(Select all options that apply)
License