Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run installed Galaxy with no config and a simplified entry point #19050

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Oct 23, 2024

Building off #17102, make it possible to start and run a simple Galaxy web server using a single command when running from installed packages and the prebuilt client. Also delays conda auto-init util the first time an install is attempted. disables conda auto-init when running installed.

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    python -m venv /tmp/galaxy/venv
    . /tmp/galaxy/venv/bin/activate
    cd packages
    ./package-dev-install.sh web_apps
    cd /tmp/galaxy
    npm install @galaxyproject/galaxy-client
    galaxy-web

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@natefoo
Copy link
Member Author

natefoo commented Oct 25, 2024

This is ready for review

Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Although I didn't test the install locally.

@@ -386,7 +386,8 @@ mapping:
required: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the default from the line above like we do for managed_config_dir and data_dir.

Comment on lines +985 to +986
if not running_from_source and kwargs.get("conda_auto_init") is None:
self.config_dict["conda_auto_init"] = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if not running_from_source and kwargs.get("conda_auto_init") is None:
self.config_dict["conda_auto_init"] = False
if kwargs.get("conda_auto_init") is None:
self.config_dict["conda_auto_init"] = running_from_source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants